linux-kernel - Re: [RFC PATCH v2 8/9] smp: refactor on_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120108161401.GE21765@n2100.arm.linux.org.uk>
Date:	Sun, 8 Jan 2012 16:14:01 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Gilad Ben-Yossef <gilad@...yossef.com>
Cc:	linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	linuxppc-dev@...ts.ozlabs.org, devicetree-discuss@...ts.ozlabs.org,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>, linux-alpha@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>, linux-ia64@...r.kernel.org,
	Will Deacon <will.deacon@....com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning
	func

On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote:
> on_each_cpu returns the retunr value of smp_call_function
> which is hard coded to 0.
> 
> Refactor on_each_cpu to a void function and the few callers
> that check the return value to save compares and branches.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Reviewed-by: Michal Nazarewicz <mina86@...a86.com>
> CC: David Airlie <airlied@...ux.ie>
> CC: dri-devel@...ts.freedesktop.org
> CC: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> CC: Paul Mackerras <paulus@...ba.org>
> CC: Grant Likely <grant.likely@...retlab.ca>
> CC: Rob Herring <rob.herring@...xeda.com>
> CC: linuxppc-dev@...ts.ozlabs.org
> CC: devicetree-discuss@...ts.ozlabs.org
> CC: Richard Henderson <rth@...ddle.net>
> CC: Ivan Kokshaysky <ink@...assic.park.msu.ru>
> CC: Matt Turner <mattst88@...il.com>
> CC: linux-alpha@...r.kernel.org
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Ingo Molnar <mingo@...hat.com>
> CC: "H. Peter Anvin" <hpa@...or.com>
> CC: x86@...nel.org
> CC: Tony Luck <tony.luck@...el.com>
> CC: Fenghua Yu <fenghua.yu@...el.com>
> CC: linux-ia64@...r.kernel.org
> CC: Will Deacon <will.deacon@....com>
> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> CC: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> CC: Russell King <linux@....linux.org.uk>

As there's only one place in the ARM code where we look at the return
value, and you've patched that away in patch 1, this looks fine.  I've
not checked for users outside of arch/arm, so:

Acked-by: Russell King <rmk+kernel@....linux.org.uk>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/