linux-kernel - Re: [PATCH v2] add led driver for Bachmann's ot200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F0AE2BF.6080605@metafoo.de>
Date:	Mon, 09 Jan 2012 13:51:11 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	christian.gmeiner@...il.com
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	bigeasy@...utronix.de, rpurdie@...ys.net
Subject: Re: [PATCH v2] add led driver for Bachmann's ot200

On 01/09/2012 11:24 AM, Christian Gmeiner wrote:
> From a7fecf3426ef98fdd19e9d2610665b9d1ce358a0 Mon Sep 17 00:00:00 2001
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de
> <mailto:bigeasy@...utronix.de>>
> Date: Mon, 9 Jan 2012 10:09:50 +0100
> Subject: [PATCH v2] add led driver for Bachmann's ot200
> 
> This patch adds support for leds on Bachmann's ot200 visualisation device.
> The device has three leds on the back panel (led_err, led_init and led_run)
> and can handle up to seven leds on the front panel.
> 
> The driver was written by Linutronix on behalf of
> Bachmann electronic GmbH.
> 
> Changes in v2:
> - *incorporated* feedback from Andrew Morton and Lars-Peter Clausen
> 

looks good to me except some minor style issues and the <mailto:...> tags.

> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de
> <mailto:bigeasy@...utronix.de>>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@...il.com
> <mailto:christian.gmeiner@...il.com>>
> ---
> [...]
> diff --git a/drivers/leds/leds-ot200.c b/drivers/leds/leds-ot200.c
> new file mode 100644
> index 0000000..4d000ac
> --- /dev/null
> +++ b/drivers/leds/leds-ot200.c
> @@ -0,0 +1,177 @@
> [...]
> +
> +static int __devinit ot200_led_probe(struct platform_device *pdev)
> +{
> +    int i;
> +    int ret;
> +
> +    for (i = 0; i < ARRAY_SIZE(leds); i++) {
> +
> +        leds[i].cdev.name = leds[i].name;
> +        leds[i].cdev.default_trigger = NULL;
> +        leds[i].cdev.blink_set = NULL;

No need to initialize to NULL.

> +        leds[i].cdev.brightness_set = ot200_led_brightness_set;
> +
> +        ret = led_classdev_register(&pdev->dev, &leds[i].cdev);
> +        if (ret < 0)
> +            goto err;
> +
> +        dev_set_drvdata(leds[i].cdev.dev, &leds[i]);

Neither this ...

> +    }
> +
> +    platform_set_drvdata(pdev, leds);

nor this is ever used.

> +
> +    outb(0x0, 0x49);    /* turn off all front leds */
> +    outb(0x2, 0x5a);    /* turn on init led */
> +    leds_front = 0;
> +    leds_back = BIT(1);

Maybe initialize leds_front and leds_back first and pass it to outb.

> +
> +    return 0;
> +
> +err:
> +    for (i = i - 1; i >= 0; i--)
> +        led_classdev_unregister(&leds[i].cdev);
> +
> +    return ret;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/