linux-kernel - Re: [PATCH 1/2] block: introduce BIO_IN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120109164148.GB21732@google.com>
Date:	Mon, 9 Jan 2012 08:41:48 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Namhyung Kim <namhyung.kim@....com>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] block: introduce BIO_IN_FLIGHT flag

Hello,

On Mon, Jan 09, 2012 at 11:57:43AM +0900, Namhyung Kim wrote:
> I understand your concerns. However, the blktrace cannot get
> bio->bi_flags info in its current form AFAIK. Doing it will require
> extending struct blk_io_trace and it'll cause a compatibility issue,
> I guess.

Umm?  Why can't blk_add_trace_bio_complete() look at the flags (or
whatever other states) to decide to fire off BLK_TA_COMPLETE or not?
What's the difference?  No userland visible change is necessary at
all.  Just make blktrace.c do the right thing.  Am I missing
something?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/