linux-kernel - Re: [BUG] kernel freezes with latest tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1326213442.19095.9.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 10 Jan 2012 17:37:22 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] kernel freezes with latest tree

Le mardi 10 janvier 2012 à 08:28 -0800, Linus Torvalds a écrit :
> On Tue, Jan 10, 2012 at 8:13 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> >
> > Here are two traces of the lockups, since I had some free time to reproduce the
> > bug on current tree (plus a minor change in bnx2 driver to avoid a
> > netconsole related stack trace)
> 
> Hmm. You have load_balance() and idle_balance() there in the trace, so
> I'm getting more hopeful that it really is just the fact that
> set_cpu_sd_state_idle() really needs to just be run with interrupts
> disabled. That was my main concern about that merge, so if it's that,
> I'll be relieved.
> 
> If you can please try that change out, that would be great.
> 
> [ And if that's not it - Ingo & co, please check out the traces on lkml ]
> 

Just to make sure I understood well, here is what I tested :


diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 7656642..acd88a1 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -466,6 +466,8 @@ void tick_nohz_idle_enter(void)
 
 	WARN_ON_ONCE(irqs_disabled());
 
+	local_irq_disable();
+
 	/*
  	 * Update the idle state in the scheduler domain hierarchy
  	 * when tick_nohz_stop_sched_tick() is called from the idle loop.
@@ -474,8 +476,6 @@ void tick_nohz_idle_enter(void)
  	 */
 	set_cpu_sd_state_idle();
 
-	local_irq_disable();
-
 	ts = &__get_cpu_var(tick_cpu_sched);
 	/*
 	 * set ts->inidle unconditionally. even if the system did not


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/