linux-kernel - Re: [BUG] kernel freezes with latest tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyyZUJHELdbKfk2Gzpx9np7Ov74idttCo6+wi2+MAVG=g@mail.gmail.com>
Date:	Tue, 10 Jan 2012 08:49:16 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] kernel freezes with latest tree

On Tue, Jan 10, 2012 at 8:37 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> Just to make sure I understood well, here is what I tested :

Yup, that was it.

That was the obvious thing about the merge to check.

I suspect that what remains is now the sparse cleanups and
usecs_to_cputime64() interaction. I note that you are running on a
32-bit setup, which is where such problems would show up (because any
new casts to "unsigned long" due to the forced sparse casting would
now actually truncate a 64-bit value down.

Just to test that theory, can you try this attached patch that simply
removes the casts? That's what we used to have before adding the
stricter type-checking (other things changed too, so this may not make
any difference, but this is a "test a small change to *maybe* narrow
things down")

Martin - mind re-running sparse on the 32-bit case to see if that
shows some messed-up case?

                   Linus

View attachment "patch.diff" of type "text/x-patch" (991 bytes)