linux-kernel - Re: [PATCH] mm: vmscan: fix setting reclaim mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 20:12:44 +0800
From:	Hillf Danton <dhillf@...il.com>
To:	Mel Gorman <mgorman@...e.de>
Cc:	linux-mm@...ck.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: vmscan: fix setting reclaim mode

On Wed, Jan 11, 2012 at 12:44 AM, Mel Gorman <mgorman@...e.de> wrote:
> On Tue, Jan 10, 2012 at 11:58:03PM +0800, Hillf Danton wrote:
>> From: Hillf Danton <dhillf@...il.com>
>> [PATCH] mm: vmscan: fix setting reclaim mode
>>
>> The comment says, initially assume we are entering either lumpy reclaim or
>> reclaim/compaction, and depending on the reclaim order, we will either set the
>> sync mode or just reclaim order-0 pages later.
>>
>> On other hand, order-0 reclaim, instead of sync reclaim, is expected when
>> under memory pressure, but the check for memory pressure is incorrect,
>> leading to sync reclaim at low reclaim priorities.
>>
>> And the result is sync reclaim is set for high priorities.
>>
>
> RECLAIM_MODE_SYNC is only set for RECLAIM_MODE_LUMPYRECLAIM. Even when
> using RECLAIM_MODE_LUMPYRECLAIM, it should only be set when reclaim
> is under memory pressure and failing to reclaim the necessry pages
> (priority < DEF_PRIORITY - 2). Once in symc reclaim, reclaim will call
> wait_on_page_writeback() on dirty pages which potentially leads to
> significant stalls (one of the reasons why RECLAIM_MODE_LUMPYRECLAIM
> sucks and why compaction is preferred). Your patch means sync reclaim
> is used even when priority == DEF_PRIORITY. This is unexpected.
>

Got and thanks for correcting Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/