linux-kernel - Re: [PATCH 1/4] staging/xgifb: Remove unsupported mode LCD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120115185445.GB3356@mwanda>
Date:	Sun, 15 Jan 2012 21:54:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Arnaud Patard <arnaud.patard@...-net.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging/xgifb: Remove unsupported mode LCD_320x480

On Sun, Jan 15, 2012 at 07:22:10PM +0100, Peter Huewe wrote:
> This patch removes the probed mode LCD_320x480 which isn't supported
> anyway since this mode falls through to the default (=invalid) mode in the
> XGIfb_validate_mode function (see line 529 ff. for details).
> 
> By removing this assignment, we can use the LCD_TYPEs from the sis
> driver without modifications.
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>  drivers/staging/xgifb/XGI_main_26.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 2502c49..c27dbf8 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -2118,10 +2118,13 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
>  			reg &= 0x0f;
>  			hw_info->ulCRT2LCDType = XGI310paneltype[reg];
>  
> -		} else {
> +		}
> +		#if 0

Uh...  Why not just delete this code and the code in
XGIfb_validate_mode() as well?

regards,
dan carepenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)