linux-kernel - Re: [PATCH] blutetooth: Remove bogus inline for l2cap_chan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120115105203.GA12584@x220.P-661HNU-F1>
Date:	Sun, 15 Jan 2012 12:52:03 +0200
From:	Johan Hedberg <johan.hedberg@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"Gustavo F. Padovan" <padovan@...fusion.mobi>,
	Marcel Holtmann <marcel@...tmann.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blutetooth: Remove bogus inline for l2cap_chan_connect()

Hi Geert,

On Sun, Jan 15, 2012, Geert Uytterhoeven wrote:
> commit 03a001948166d966d0d580cddb8ae3a23f8b795b ("Bluetooth: invert locking
> order in connect path") marked l2cap_chan_connect() inline for both the
> prototype in include/net/bluetooth/l2cap.h and the implementation in
> net/bluetooth/l2cap_core.c.
> 
> As the former doesn't contain an implementation, net/bluetooth/l2cap_sock.c
> now fails to build, e.g. for m68k allmodconfig:
> 
>     net/bluetooth/l2cap_sock.c: In function ‘l2cap_sock_connect’:
>     include/net/bluetooth/l2cap.h:838: sorry, unimplemented: inlining failed in call to ‘l2cap_chan_connect’: function body not available
>     net/bluetooth/l2cap_sock.c:126: sorry, unimplemented: called from here
>     make[1]: *** [net/bluetooth/l2cap_sock.o] Error 1
> 
> As l2cap_chan_connect() is not that small and also called from
> net/bluetooth/l2cap_sock.c, I removed both inline keywords.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> --
> As I can't seem to find anyone else getting this, I guess it's only
> triggered by some versions of gcc. Mine is
> 
> gcc version 4.1.2 20061115 (prerelease) (Ubuntu 4.1.1-21)
> ---
>  include/net/bluetooth/l2cap.h |    2 +-
>  net/bluetooth/l2cap_core.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This was already reported[1] earlier this month and a patch[2] was also
created for it which right now resides in my bluetooth-next tree[3].

Johan

[1] http://www.spinics.net/lists/linux-bluetooth/msg19851.html
[2] http://www.spinics.net/lists/linux-bluetooth/msg20009.html
[3] http://git.kernel.org/?p=linux/kernel/git/jh/bluetooth-next.git;a=commitdiff;h=cd555072d0b0738c8a107776fe91902da686f94d
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/