linux-kernel - Re: [PATCH] mfd: variable dereferenced before check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120115111553.GA3040@opensource.wolfsonmicro.com>
Date:	Sun, 15 Jan 2012 03:15:55 -0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	jhbird.choi@...sung.com, Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] mfd: variable dereferenced before check

On Fri, Jan 13, 2012 at 10:40:52AM +0900, jhbird.choi@...sung.com wrote:
> From: Jonghwan Choi <jhbird.choi@...sung.com>
> 
> Remove "wm8350->irq_base = pdata->irq_base" to avoid
> null pointer exception and wm8350->irq_base got from
> irq_alloc_descs().

Always send patches to the relevant maintainers - for the MFD subsystem
the maintainer is Samuel Ortiz.

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

> 
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  drivers/mfd/wm8350-irq.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
> index 8a1fafd..9fd01bf 100644
> --- a/drivers/mfd/wm8350-irq.c
> +++ b/drivers/mfd/wm8350-irq.c
> @@ -496,7 +496,6 @@ int wm8350_irq_init(struct wm8350 *wm8350, int irq,
>  
>  	mutex_init(&wm8350->irq_lock);
>  	wm8350->chip_irq = irq;
> -	wm8350->irq_base = pdata->irq_base;
>  
>  	if (pdata && pdata->irq_base > 0)
>  		irq_base = pdata->irq_base;
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/