linux-kernel - RE: [GIT PULL] Block drivers for 3.3-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80B89753B40C5141A3E2D53FE7A2A8A91968752B@NTXBOIMBX02.micron.com>
Date:	Mon, 16 Jan 2012 19:13:18 +0000
From:	"Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>
To:	Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@...radead.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]" 
	<asamymuthupa@...ron.com>
Subject: RE: [GIT PULL] Block drivers for 3.3-rc

> On 2012-01-15 11:33, Christoph Hellwig wrote:
> > On Sun, Jan 15, 2012 at 10:52:12AM +0100, Jens Axboe wrote:
> >> Hi Linus,
> >>
> >> Please see below for the 3.3-rc1 block driver pull request.
> >>
> >> Essentially two different categories here:
> >>
> >> - Adds the driver for the Micron RealSSD P320 pci-express flash card.
> >
> > The REQ_FUA and REQ_FLUSH handling in it is still completely broken,
> > with no attempt to fix it since it last came up.
> >
> > So a pretty clear NAK on that driver from me.
> 
> Good point, I had forgotten about the ordered writes, I believe the rest
> of the items have been handled. The driver/hw, as it stands, does not
> reorder writes and it doesn't have a write back cache. So it should
> actually be safe. Any acked write is stable. Sam, correct me if I'm
> wrong.

That's correct, Jens.  Neither the driver nor the hardware reorders commands so we choose to ignore barriers.  I see now that the "barrier" parameter in the function is rather unfortunately named.  We'll fix that.

-Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/