linux-kernel - Re: [PATCH 1/2] gpio-pch: cleanup _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F153221.3080509@freemail.hu>
Date:	Tue, 17 Jan 2012 09:32:33 +0100
From:	Németh Márton <nm127@...email.hu>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio-pch: cleanup __iomem annotation usage

Hi Linux,

Linus Walleij wrote:
> 2012/1/15 Németh Márton <nm127@...email.hu>:
> 
>> From: Márton Németh <nm127@...email.hu>
>>
>> The __iomem annotation is to be used together with pointers used
>> as iowrite32() parameter. For more details see [1] and [2].
> (...)
>> -       u32 *im_reg;
>> +       u32 __iomem *im_reg;
> 
> Does it work to just say void __iomem *im_reg?
> 
> We usually don't type addresses.

You are right, the correct one should be "void __iomem *im_reg;" .

Should I resend a patch for this?

	Márton Németh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/