linux-kernel - Re: [patch 2/2] mm: memcg: hierarchical soft limit reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118152708.GG31112@tiehlicka.suse.cz>
Date:	Wed, 18 Jan 2012 16:27:08 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Sha <handai.szj@...il.com>
Cc:	Johannes Weiner <hannes@...xchg.org>,
	Ying Han <yinghan@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Balbir Singh <bsingharora@...il.com>, cgroups@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 2/2] mm: memcg: hierarchical soft limit reclaim

On Wed 18-01-12 19:25:27, Sha wrote:
[...]
> Er... I'm even more confused: mem_cgroup_soft_limit_reclaim indeed
> choses the biggest soft-limit excessor first, but in the succeeding reclaim
> mem_cgroup_hierarchical_reclaim just selects a child cgroup  by css_id

mem_cgroup_soft_limit_reclaim picks up the hierarchy root (most
excessing one) and mem_cgroup_hierarchical_reclaim reclaims from that
subtree). It doesn't care who exceeds the soft limit under that
hierarchy it just tries to push the root under its limit as much as it
can. This is what Johannes tried to explain in the other email in the
thred.

> which has nothing to do with soft limit (see mem_cgroup_select_victim).
> IMHO, it's not a genuine hierarchical reclaim.

It is hierarchical because it iterates over hierarchy it is not and
never was recursively soft-hierarchical...

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/