linux-kernel - Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118185457.GH3356@mwanda>
Date:	Wed, 18 Jan 2012 21:54:57 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Pradheep Shrinivasan <pradheep.sh@...il.com>,
	Andy Whitcroft <apw@...onical.com>
Cc:	greg@...ah.com, devel@...uxdriverproject.org, swetland@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other
 formating issues pointed out by checkpatch.pl

On Wed, Jan 18, 2012 at 11:38:34PM +0530, Pradheep Shrinivasan wrote:
>> > > -#define PMEM_IOCTL_MAGIC 'p'
> > > +#define PMEM_IOCTL_MAGIC ('p')
> >
> > You don't need parenthesis here.  Did checkpatch really complain
> > about this?
>
> Yes the check patch does complain about the parenthesis.
> 
> pradheep@...ntu:~/linux-next/
> linux-next/drivers/staging/android$ checkpatch android_pmem.h
> android_pmem.h:10: ERROR: trailing whitespace
> android_pmem.h:19: ERROR: Macros with complex values should be enclosed in
> parenthesis

That seems like a bug in checkpatch.pl.  It's hard to imagine less
complex macro than:  #define PMEM_IOCTL_MAGIC 'p'

Perhaps if the check looked for one of these characters: */+-=<>|&

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)