linux-kernel - Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAq6er0OPkvTCLt1DvHSjyqM4pH7GMb-D78M09cJY+1ZV3miiQ@mail.gmail.com>
Date:	Fri, 20 Jan 2012 11:12:55 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Pradheep Shrinivasan <pradheep.sh@...il.com>, greg@...ah.com,
	devel@...uxdriverproject.org, swetland@...gle.com,
	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other
 formating issues pointed out by checkpatch.pl

On Wed, Jan 18, 2012 at 6:54 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Wed, Jan 18, 2012 at 11:38:34PM +0530, Pradheep Shrinivasan wrote:
>>> > > -#define PMEM_IOCTL_MAGIC 'p'
>> > > +#define PMEM_IOCTL_MAGIC ('p')
>> >
>> > You don't need parenthesis here.  Did checkpatch really complain
>> > about this?
>>
>> Yes the check patch does complain about the parenthesis.
>>
>> pradheep@...ntu:~/linux-next/
>> linux-next/drivers/staging/android$ checkpatch android_pmem.h
>> android_pmem.h:10: ERROR: trailing whitespace
>> android_pmem.h:19: ERROR: Macros with complex values should be enclosed in
>> parenthesis
>
> That seems like a bug in checkpatch.pl.  It's hard to imagine less
> complex macro than:  #define PMEM_IOCTL_MAGIC 'p'

I can think of no way in which an unprotected character is different
to an unprotected integer constant.  So ...

Does the version here work better for you:

    http://people.canonical.com/~apw/checkpatch/checkpatch-next.pl

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/