linux-kernel - Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120120115408.GL3356@mwanda>
Date:	Fri, 20 Jan 2012 14:54:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Pradheep Shrinivasan <pradheep.sh@...il.com>, greg@...ah.com,
	devel@...uxdriverproject.org, swetland@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other
 formating issues pointed out by checkpatch.pl

It still complains about the following macros where parenthesis are
not needed.

ERROR: Macros with complex values should be enclosed in parenthesis
#156: FILE: staging/android/pmem.c:156:
+#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)

Let's just make the check look for an operator with a low
precedence.
http://en.wikipedia.org/wiki/Order_of_operations#Programming_languages

Otherwise the submitters are going to change it to:

#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))

That has two pairs of unneeded paranthesis and we run the risk of
reprogramming the kernel in lisp, by mistake.

regards,
dan carpenter

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)