linux-kernel - Re: build failure with current linus tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120118015122.GW23916@ZenIV.linux.org.uk>
Date:	Wed, 18 Jan 2012 01:51:22 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	JONGMAN HEO <jongman.heo@...sung.com>
Cc:	linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: build failure with current linus tree

On Wed, Jan 18, 2012 at 01:17:31AM +0000, JONGMAN HEO wrote:
> 
> With current linus git (commit a25a2b84), I got following build error,
> 
> arch/x86/kernel/vm86_32.c: In function ??do_sys_vm86??:
> arch/x86/kernel/vm86_32.c:340: error: implicit declaration of function ??__audit_syscall_exit??
> make[3]: *** [arch/x86/kernel/vm86_32.o] Error 1
> 
> I do not have CONFIG_AUDITSYSCALL in my .config.

Um...  OK, I can reproduce it (32bit allmodconfig with AUDIT=y, AUDITSYSCALL=n)
Crap...  It's "Audit: push audit success and retcode into arch ptrace.h".

Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
---
diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
index af17e1c..b466cab 100644
--- a/arch/x86/kernel/vm86_32.c
+++ b/arch/x86/kernel/vm86_32.c
@@ -336,8 +336,10 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
 		mark_screen_rdonly(tsk->mm);
 
 	/*call __audit_syscall_exit since we do not exit via the normal paths */
+#ifdef CONFIG_AUDITSYSCALL
 	if (unlikely(current->audit_context))
 		__audit_syscall_exit(1, 0);
+#endif
 
 	__asm__ __volatile__(
 		"movl %0,%%esp\n\t"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/