linux-kernel - Re: PATCH] use void __iomem * pointers for ioread32()/iowrite32()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120118210716.GN4223@ponder.secretlab.ca>
Date:	Wed, 18 Jan 2012 14:07:16 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	N?meth M?rton <nm127@...email.hu>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: PATCH] use void __iomem * pointers for ioread32()/iowrite32()

On Wed, Jan 18, 2012 at 06:18:15AM +0000, Al Viro wrote:
> On Wed, Jan 18, 2012 at 07:05:18AM +0100, N?meth M?rton wrote:
> > From: M?rton N?meth <nm127@...email.hu>
> > 
> > The address pointer of ioread32()/iowrite32() functions are
> > of type "void __iomem *". Use matching variable type.
> 
> > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> > index 68fa55e..84b7f28 100644
> > --- a/drivers/gpio/gpio-pch.c
> > +++ b/drivers/gpio/gpio-pch.c
> > @@ -231,7 +231,7 @@ static void pch_gpio_setup(struct pch_gpio *chip)
> >  static int pch_irq_type(struct irq_data *d, unsigned int type)
> >  {
> >  	u32 im;
> > -	u32 __iomem *im_reg;
> > +	void __iomem *im_reg;
> 
> NAK.  Please, learn what "function with pointer to (possibly qualified) void"
> means.  It's fairly basic C, so any (post-K&R) textbook would do.

Okay, ignoring.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/