linux-kernel - Re: [RFC] splitting cgroup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120119022401.GH21533@google.com>
Date:	Wed, 18 Jan 2012 18:24:01 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>
Subject: Re: [RFC] splitting cgroup.c

Hello,

On Thu, Jan 19, 2012 at 10:13:59AM +0800, Li Zefan wrote:
> While working on cgroup xattr, it appeared to me it's better to
> create a cgroup_xattr.c instead of stuffing things into cgroup.c.
> 
> Then I took a look at how big it is.
> 
>     $ ls -l -S kernel/*.c
>     -rw-rw-r--  1 lizf lizf 142717 Jan 18 10:15 cgroup.c
>     -rw-rw-r--  1 lizf lizf 106498 Jan 18 10:15 workqueue.c
>     -rw-rw-r--  1 lizf lizf 105206 Jan 18 10:15 lockdep.c
>     -rw-rw-r--  1 lizf lizf  91321 Jan 18 10:16 module.c
>     
>     $ wc -l kernel/*.c | sort -n -r
>       90397 total
>        5289 cgroup.c
>        4206 lockdep.c
>        3840 workqueue.c
>        3507 module.c

Yeah, cgroup.c one giant file.

> So I think for the sake of readability and maintainability, we'd
> better split cgroup.c into smaller pieces:

I agree that splitting is necessary but IMHO splitting usually tends
to go too far.  Maybe we can split it into two and think about further
splitting later on?  e.g. internal logic vs. userland interfacing.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/