linux-kernel - Re: [PATCH] Add Winbond WB528SD Secure Digital (SD) card reader driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120121125153.GB18829@suse.de>
Date:	Sat, 21 Jan 2012 07:51:53 -0500
From:	Greg KH <gregkh@...e.de>
To:	Németh Márton <nm127@...email.hu>
Cc:	Chris Ball <cjb@...top.org>, linux-mmc@...r.kernel.org,
	devel@...verdev.osuosl.org, techeng <dzshen@...il.com>,
	clyu@...iz.net, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Add Winbond WB528SD Secure Digital (SD) card reader
 driver

On Sat, Jan 21, 2012 at 11:52:37AM +0100, Németh Márton wrote:
> From: Márton Németh <nm127@...email.hu>
> 
> This driver version of Winbond WB528SD can detect mechanical card
> presence only. The information is provided through sysfs.

How is it provided through sysfs?  Is this done in a standard way?  If
not, why not?

Why is this driver submitted to the staging tree?  What is keeping it
from going into the "real" portion of the kernel for other card readers?

We need a TODO file for what is needed to get it moved out of staging.

Oh, and it needs to do a bit more than just detect a card to be useful,
right?  How about read/write to it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/