linux-kernel - Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEMzQTZ5ASCrrDJ6KSe41=yKL+7ayo_LfkZh3vagcopiGAj1tQ@mail.gmail.com>
Date:	Sat, 21 Jan 2012 09:18:43 -0800
From:	sam hansen <solid.se7en@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Arnaud Patard <arnaud.patard@...-net.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

> These last two should be KERN_CONT
> though the block could be rewritten as
>
>        if (XGIInitNew(pdev))
>                printk(KERN_INFO "XGIfb: XGIInitNew() ... OK\n");
>        else
>                printk(KERN_ERR "XGIfb: XGIInitNew() ... Fail\n");
>
> Emitting any dmesg output like "XGIInitNew() ... OK\n"
> is almost always low value.
>
> Perhaps just emitting on the error case is better:
>        if (!XGIInitNew(pdev))
>                printk(KERN_ERR "XGIfb: XBIInitNew() failed\n");

Cool.  See Re: Dan.  I will fold the printk logic up.

> One other thing.  It would be better to add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include and convert all the
> printks(KERN_<LEVEL> to pr_<level>(
> stripping all the leading XGIfb: too.

I might take a stab at eliminating explicit calls to printk and use a macro.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/