linux-kernel - Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEMzQTZZnPfGK4CZGw+PraL59f4C8eADfvpaGUrVd38d5TFA+A@mail.gmail.com>
Date:	Sat, 21 Jan 2012 11:22:38 -0800
From:	sam hansen <solid.se7en@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Arnaud Patard <arnaud.patard@...-net.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*

> One other thing.  It would be better to add
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include and convert all the
> printks(KERN_<LEVEL> to pr_<level>(
> stripping all the leading XGIfb: too.

So, an administrative question.  Sorry for my noob-ishness but... I
will be 1) modifying the patch regarding prink to use pr_LVL (and a
few logic tweaks), and will also be introducing a new patch to set up
the pr_fmt macro for kbuild.  I can find lots of information regarding
how to create/submit a patch, but not a lot of information about how
to modify/resubmit a patch you've already submitted and received
feedback for.

The pr_fmt patch will likely just be a new patch outside of this patch
set?  Or should I use git-rebase to work it in the middle of the patch
set and regenerate/resend all patches (this approach doesn't seem to
make sense).

I'm not sure how the git commit short-hashes work with the patches,
and I don't want to destroy that information because it seems like
it's important when stuff goes upstream?

Thanks for any feedback you guys may have :)

And thanks for helping me pull myself up to actually being useful to you all.

~s
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/