linux-kernel - Re: [PATCH 1/2] Staging: android: binder: Add some error checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120121082208.GL3294@mwanda>
Date:	Sat, 21 Jan 2012 11:22:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Arve Hjønnevåg <arve@...roid.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Christopher Lais <chris+android@...thought.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [PATCH 1/2] Staging: android: binder: Add some error checks

On Fri, Jan 20, 2012 at 07:56:20PM -0800, Arve Hjønnevåg wrote:
> - Add a mutex to protect against two processes mmapping the
>   same binder_proc.
> - After locking mmap_sem, check that the vma we want to access
>   (still) points to the same mm_struct.
> - Use proc->tsk instead of current to get the files struct since
>   this is where we get the rlimit from.

This doesn't seem related to the locking change at all.  Probably
this patch should be split into three patches, one bugfix per
patch, unless they are very closely related.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)