linux-kernel - Re: [PATCH 6/6] Staging: android: Add parenthesis to macros with complex values in pmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120121082416.GM3294@mwanda>
Date:	Sat, 21 Jan 2012 11:24:16 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Kashyap Gada <gada.kashyap@...il.com>
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, dima@...roid.com, jgennis@...gle.com,
	rebecca@...roid.com
Subject: Re: [PATCH 6/6] Staging: android: Add parenthesis to macros with
 complex values in pmem.c

On Sat, Jan 21, 2012 at 04:23:32AM +0000, Kashyap Gada wrote:
> -#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
> -#define PMEM_ORDER(id, index) pmem[id].bitmap[index].order
> +#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
> +#define PMEM_ORDER(id, index) (pmem[id].bitmap[index].order)

These are not needed.  We're modifying checkpatch.pl to not complain
about these, but it hasn't been merged yet.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)