| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jan 2012 10:12:22 -0800 From: Kees Cook <keescook@...omium.org> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Randy Dunlap <rdunlap@...otime.net>, Andrew Morton <akpm@...ux-foundation.org>, Borislav Petkov <bp@...en8.de>, Vasiliy Kulikov <segoon@...nwall.com>, Dan Ballard <dan@...dstab.net>, Jiri Kosina <jkosina@...e.cz>, Al Viro <viro@...iv.linux.org.uk>, Stephen Wilson <wilsons@...rt.ca>, David Rientjes <rientjes@...gle.com>, Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Eric Paris <eparis@...hat.com>, "Serge E. Hallyn" <serge.hallyn@...onical.com>, linux-doc@...r.kernel.org Subject: Re: [PATCH v2] sysctl: control functionality of /proc/pid/mem On Mon, Jan 23, 2012 at 6:41 AM, Eric W. Biederman <ebiederm@...ssion.com> wrote: >> +#ifdef CONFIG_PROC_FS > ^^^^^^^^^^^^^^^^^^^^^^ > > That ifdef is entertaining. CONFIG_SYSCTL depends on CONFIG_PROC_FS > so which interesting case did you imagine this ifdef would be false? > Did you test to ensure the code is not compiled in that interesting case? I noticed that when I added it, and decided to err on the side of more configs if some day /proc/sys got moved out of /proc. Anyway, I can easily remove it. v3 coming up... -Kees -- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists