linux-kernel - Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jan 2012 15:09:23 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Asai Thambi SP <asaithambisp@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	Christoph Hellwig <hch@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>,
	Asai Thambi S P <asamymuthupa@...ron.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of
 mtip_hw_submit_io()

On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote:
> This device does not support write cache, hence renamed confusing argument
> 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility.

That's not correct, you set it if REQ_FUA is set, which won't ever be
set given how you configure the queue. I.e. it's dead code that can be
removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/