linux-kernel - RE: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80B89753B40C5141A3E2D53FE7A2A8A919691477@NTXBOIMBX02.micron.com>
Date:	Mon, 23 Jan 2012 20:21:35 +0000
From:	"Sam Bradshaw (sbradshaw)" <sbradshaw@...ron.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Asai Thambi SP <asaithambisp@...il.com>
CC:	Jens Axboe <axboe@...nel.dk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]" 
	<asamymuthupa@...ron.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mtip32xx: rename the confusing argument 'barrier', of
 mtip_hw_submit_io()


> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@...radead.org]
> Subject: Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of
> mtip_hw_submit_io()
> 
> On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote:
> > This device does not support write cache, hence renamed confusing argument
> > 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility.
> 
> That's not correct, you set it if REQ_FUA is set, which won't ever be
> set given how you configure the queue. I.e. it's dead code that can be
> removed.

That was done intentionally to minimize the scope of changes for future 
variants of the P320 that do support write cache.  We'll go ahead and
remove it, however, since it is presently dead code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/