linux-kernel - Re: [RFCv3 0/9] perf tool: parser generator for events parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120125170151.GB5311@kroah.com>
Date:	Wed, 25 Jan 2012 09:01:51 -0800
From:	Greg KH <greg@...ah.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Jiri Olsa <jolsa@...hat.com>, acme@...hat.com, mingo@...e.hu,
	paulus@...ba.org, cjashfor@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org
Subject: Re: [RFCv3 0/9] perf tool: parser generator for events parsing

On Wed, Jan 25, 2012 at 11:49:33AM +0100, Peter Zijlstra wrote:
> On Tue, 2012-01-24 at 16:53 -0800, Greg KH wrote:
> 
> > Well, what's to keep someone from exploding one of those files to go
> > over the buffer size without knowing it?
> 
> The content is known at compile time, we could put checks in. But yeah
> 4k isn't that much text..
> 
> > Even after reading the above link, I can't really understand what this
> > is being used for.  As it's sysfs files, why aren't Documentation/ABI/
> > files also being created with the patch explaining it all?
> 
> Ah, yeah, documentation, wasn't that written in C :-)
> 
> But fair enough... Anyway, the purpose is to describe the magic bits
> that go into perf_event_attr::config[012] for a particular pmu.
> 
> Basically they're the 'hardware' bitmasks we want to export, so that
> userspace can deal with sane name/value pairs.
> 
> > Again, if at all possible, sysfs should be one value per file.  Please
> > NEVER create a sysfs file that requires a parser to determine what is
> > going on in it.  It should be a simple 'read the value' type thing.
> 
> The whole purpose was to drive a parser :-) Anyway, is:
> "config:0-7,32-35" acceptable for a single file?
> 
> This means, the 'config' member of struct perf_event_attr bits 0-7,32-35
> form a bitfield whose name is then given by the filename that has this
> content.

Yes, that would be fine.

> > So yes, multiple sysfs files do make sense, the resource load should be
> > almost non-existant for new ones.
> 
> Surely all these attribute objects take more space than a few lines of
> text, but ok, I guess multiple files it is.

Great, thanks for asking.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/