[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120126110506.GB2611@pengutronix.de>
Date: Thu, 26 Jan 2012 12:05:06 +0100
From: Wolfram Sang <w.sang@...gutronix.de>
To: Julia Lawall <julia.lawall@...6.fr>
Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
Takashi Iwai <tiwai@...e.de>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Dong Aisheng-B29396 <B29396@...escale.com>,
Liam Girdwood <lrg@...com>
Subject: Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add
missing iounmap
> @@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device *pdev)
> goto failed_get_resource;
> }
>
> - if (!request_mem_region(iores->start, resource_size(iores),
> - "mxs-saif")) {
> + if (!devm_request_mem_region(&pdev->dev, iores->start,
> + resource_size(iores), "mxs-saif")) {
> dev_err(&pdev->dev, "request_mem_region failed\n");
> ret = -EBUSY;
> goto failed_get_resource;
> }
>
> - saif->base = ioremap(iores->start, resource_size(iores));
> + saif->base = devm_ioremap(&pdev->dev, iores->start,
> + resource_size(iores));
devm_request_and_ioremap() to save even more code?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists