[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1201261220460.1851@localhost6.localdomain6>
Date: Thu, 26 Jan 2012 12:21:35 +0100 (CET)
From: Julia Lawall <julia.lawall@...6.fr>
To: Wolfram Sang <w.sang@...gutronix.de>
cc: Julia Lawall <julia.lawall@...6.fr>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
Takashi Iwai <tiwai@...e.de>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Dong Aisheng-B29396 <B29396@...escale.com>,
Liam Girdwood <lrg@...com>
Subject: Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing
iounmap
On Thu, 26 Jan 2012, Wolfram Sang wrote:
>> @@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device *pdev)
>> goto failed_get_resource;
>> }
>>
>> - if (!request_mem_region(iores->start, resource_size(iores),
>> - "mxs-saif")) {
>> + if (!devm_request_mem_region(&pdev->dev, iores->start,
>> + resource_size(iores), "mxs-saif")) {
>> dev_err(&pdev->dev, "request_mem_region failed\n");
>> ret = -EBUSY;
>> goto failed_get_resource;
>> }
>>
>> - saif->base = ioremap(iores->start, resource_size(iores));
>> + saif->base = devm_ioremap(&pdev->dev, iores->start,
>> + resource_size(iores));
>
> devm_request_and_ioremap() to save even more code?
I didn't do that because apparently it is not yet in a release? I have
another for introducing those...
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists