[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120126175612.GA24011@redhat.com>
Date: Thu, 26 Jan 2012 18:56:12 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Arjan van de Ven <arjan@...ux.intel.com>,
Rusty Russell <rusty@...tcorp.com.au>,
Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: + kmod-avoid-deadlock-by-recursive-kmod-call.patch added to
-mm tree
> @@ -449,6 +460,16 @@ int call_usermodehelper_exec(struct subp
> retval = -EBUSY;
> goto out;
> }
> + /*
> + * Worker thread must not wait for khelper thread at below
> + * wait_for_completion() if the thread was created with CLONE_VFORK
> + * flag, for khelper thread is already waiting for the thread at
> + * wait_for_completion() in do_fork().
> + */
> + if (wait != UMH_NO_WAIT && current == kmod_thread_locker) {
> + retval = -EBUSY;
> + goto out;
> + }
So, this is because khelper_wq's max_active == 1.
Can't we simply kill khelper_wq and use system_unbound_wq instead?
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists