[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1327670668.14789.4.camel@lappy>
Date: Fri, 27 Jan 2012 08:24:28 -0500
From: Sasha Levin <levinsasha928@...il.com>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: David Miller <davem@...emloft.net>, eric.dumazet@...il.com,
xemul@...allels.com, sjur.brandeland@...ricsson.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
davej@...hat.com, sjurbren@...il.com
Subject: Re: [PATCH 2/2] net caif: Register properly as a pernet subsystem.
On Thu, 2012-01-26 at 16:04 -0800, Eric W. Biederman wrote:
> caif is a subsystem and as such it needs to register with
> register_pernet_subsys instead of register_pernet_device.
>
> Among other problems using register_pernet_device was resulting in
> net_generic being called before the caif_net structure was allocated.
> Which has been causing net_generic to fail with either BUG_ON's or by
> return NULL pointers.
>
> A more ugly problem that could be caused is packets in flight why the
> subsystem is shutting down.
>
> To remove confusion also remove the cruft cause by inappropriately
> trying to fix this bug.
>
> With the aid of the previous patch I have tested this patch and
> confirmed that using register_pernet_subsys makes the failure go away
> as it should.
>
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
I've tested these two patches as well, and they also work for me.
Tested-by: Sasha Levin <levinsasha928@...il.com>
--
Sasha.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists