linux-kernel - RE: [PATCH 2/2] net caif: Register properly as a pernet subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81C3A93C17462B4BBD7E272753C105791FB48AD1FB@EXDCVYMBSTM005.EQ1STM.local>
Date:	Fri, 27 Jan 2012 15:48:00 +0100
From:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>
To:	Sasha Levin <levinsasha928@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"xemul@...allels.com" <xemul@...allels.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"davej@...hat.com" <davej@...hat.com>,
	"sjurbren@...il.com" <sjurbren@...il.com>
Subject: RE: [PATCH 2/2] net caif:  Register properly as a pernet subsystem.

> > caif is a subsystem and as such it needs to register with
> > register_pernet_subsys instead of register_pernet_device.
> >
> > Among other problems using register_pernet_device was resulting in
> > net_generic being called before the caif_net structure was allocated.
> > Which has been causing net_generic to fail with either BUG_ON's or by
> > return NULL pointers.
> >
> > A more ugly problem that could be caused is packets in flight why the
> > subsystem is shutting down.
> >
> > To remove confusion also remove the cruft cause by inappropriately
> > trying to fix this bug.
> >
> > With the aid of the previous patch I have tested this patch and
> > confirmed that using register_pernet_subsys makes the failure go away
> > as it should.
> >
> > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> 
> I've tested these two patches as well, and they also work for me.
> 
> 	Tested-by: Sasha Levin <levinsasha928@...il.com>

This looks very good to me, thank you Eric. 

Acked-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/