[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120127102218.3dde7360@jbarnes-desktop>
Date: Fri, 27 Jan 2012 10:22:18 -0800
From: Jesse Barnes <jbarnes@...tuousgeek.org>
To: Yinghai Lu <yinghai@...nel.org>
Cc: Ram Pai <linuxram@...ibm.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/21] PCI: Disable cardbus bridge MEM1 pref CTL
On Sat, 21 Jan 2012 02:08:33 -0800
Yinghai Lu <yinghai@...nel.org> wrote:
> Some BIOS enable both pref for MEM0 and MEM1.
>
> but we assume MEM1 is non-pref...
>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> ---
> drivers/pci/setup-bus.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 090217a..d5897c3 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -914,6 +914,14 @@ static void pci_bus_size_cardbus(struct pci_bus *bus,
> if (realloc_head)
> add_to_list(realloc_head, bridge, b_res+1, pci_cardbus_io_size, 0 /* dont care */);
>
> + /* MEM1 must not be pref mmio */
> + pci_read_config_word(bridge, PCI_CB_BRIDGE_CONTROL, &ctrl);
> + if (ctrl & PCI_CB_BRIDGE_CTL_PREFETCH_MEM1) {
> + ctrl &= ~PCI_CB_BRIDGE_CTL_PREFETCH_MEM1;
> + pci_write_config_word(bridge, PCI_CB_BRIDGE_CONTROL, ctrl);
> + pci_read_config_word(bridge, PCI_CB_BRIDGE_CONTROL, &ctrl);
> + }
> +
> /*
> * Check whether prefetchable memory is supported
> * by this bridge.
Is there an actual bug report for this one where prefetchable regions
are causing trouble? I can see that they would I just wonder if this
bug is hidden by some other...
--
Jesse Barnes, Intel Open Source Technology Center
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists