[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120127102311.6027ea2c@jbarnes-desktop>
Date: Fri, 27 Jan 2012 10:23:11 -0800
From: Jesse Barnes <jbarnes@...tuousgeek.org>
To: Yinghai Lu <yinghai@...nel.org>
Cc: Ram Pai <linuxram@...ibm.com>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
Dominik Brodowski <linux@...inikbrodowski.net>
Subject: Re: [PATCH 18/21] PCI: Fix cardbus bridge resources as optional
size handling
On Sat, 21 Jan 2012 02:08:34 -0800
Yinghai Lu <yinghai@...nel.org> wrote:
> We should not set the requested size to -2.
>
> that will confuse the resource list sorting with align when SIZEALIGN is used.
>
> Change to STARTALIGN and pass align from start.
>
> We are safe to do that just as we do that regular pci bridge.
>
> In the long run, we should just treat cardbus like regular pci bridge.
>
> Also fix when realloc is not passed, should keep the requested size.
>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
I'd like to see some testing on this one... Dominik?
--
Jesse Barnes, Intel Open Source Technology Center
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists