linux-kernel - Re: [PATCH 21/21] PCI: only enable pci realloc when SRIOV bar is not assigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127102559.1c2cb65a@jbarnes-desktop>
Date:	Fri, 27 Jan 2012 10:25:59 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ram Pai <linuxram@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/21] PCI: only enable pci realloc when SRIOV bar is
 not assigned

On Sat, 21 Jan 2012 02:08:37 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> If bios does not assign those BAR or wrong address, then kernel will
> try to do pci realloc.
> 
> in that case, user still can use pci=realloc=off to override it.
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> ---
>  drivers/pci/setup-bus.c |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
> 

I worry about this one; distros may enable IOV to keep a unified kernel
binary and end up messing up all sorts of systems that happen to have
IOV devices that the user doesn't actually care about.

I'd prefer to leave it disabled by default, and let drivers spew a
message about IOV resources being unavailable and mentioning the
realloc= param...

-- 
Jesse Barnes, Intel Open Source Technology Center

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)