linux-kernel - Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120127182403.GG11086@moon>
Date:	Fri, 27 Jan 2012 22:24:03 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Pavel Emelyanov <xemul@...allels.com>,
	Andrey Vagin <avagin@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Tejun Heo <tj@...nel.org>, Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Alexey Dobriyan <adobriyan@...il.com>, Valdis.Kletnieks@...edu
Subject: Re: [RFC c/r 2/4] [RFC] syscalls, x86: Add __NR_kcmp syscall v7

On Fri, Jan 27, 2012 at 07:15:25PM +0100, Andi Kleen wrote:
> > It takes up to 5 agruments - the pids of the two tasks (which
> > characteristics should be compared), the comparision type and
> > (in case of comparision of files) two file descriptors.
> 
> Can you please write a manpage for it? That's really required
> to evaluate the interface properly.

Sure, I'll try to (btw, where I should send it to? And in which
format novadays mans are written? In plain old troff or some
human readable asciidocs?) And... should I post man page
on LKML as well?

> 
> As I understand it every time the kernel adds some new kind of state
> this would need to be extended too? This would seem like a lot of work,
> especially since you always need to synchronize kernel/user space.
> How would the user space break if it doesn't know about some newly
> added state?

Wait, maybe I should use kernel-doc here and put comments with example
right on top of SYSCALL definition?

> 
> Maybe it would be better to put more of the relevant code into the
> kernel to encapsulate this better.
> 
> 
> > +	case KCMP_SYSVSEM:
> > +#ifdef CONFIG_SYSVIPC
> > +		ret = kcmp_ptr((long)task1->sysvsem.undo_list,
> > +			       (long)task2->sysvsem.undo_list,
> > +			       KCMP_SYSVSEM);
> 
> I assume that's normally NULL.
> 

Hmm.. Andi, I seem not following. And?

> > +#ifdef CONFIG_X86_64
> > +static long syscall5(int nr, unsigned long arg0, unsigned long arg1,
> > +		unsigned long arg2, unsigned long arg3,
> > +		unsigned long arg4)
> 
> Why not just use syscall() in glibc?
> 

Never heard of it. I'll take a look, thanks. But I suppose all this
comments might be addressed in patch on top?

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/