linux-kernel - RE: [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point DeviceIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Jan 2012 18:56:39 +0000
From:	"Heasley, Seth" <seth.heasley@...el.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
CC:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ralston, James D" <james.d.ralston@...el.com>
Subject: RE: [PATCH 6/6] pci: irq and pci_ids patch for Intel Lynx Point
 DeviceIDs

>> This patch adds the LPC Controller DeviceIDs for the Intel Lynx Point
>PCH.
>>
>> Signed-off-by: Seth Heasley <seth.heasley@...el.com>
>> ---
>>  arch/x86/pci/irq.c      |    4 +++-
>>  include/linux/pci_ids.h |    2 ++
>>  2 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/pci/irq.c b/arch/x86/pci/irq.c index
>> 372e9b8..22468b6 100644
>> --- a/arch/x86/pci/irq.c
>> +++ b/arch/x86/pci/irq.c
>> @@ -604,7 +604,9 @@ static __init int intel_router_probe(struct
>irq_router *r, struct pci_dev *route
>>  	||  (device >= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MIN &&
>>  	     device <= PCI_DEVICE_ID_INTEL_DH89XXCC_LPC_MAX)
>>  	||  (device >= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MIN &&
>> -	     device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)) {
>> +	     device <= PCI_DEVICE_ID_INTEL_PANTHERPOINT_LPC_MAX)
>> +	||  (device >= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN &&
>> +	     device <= PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX)) {
>>  		r->name = "PIIX/ICH";
>>  		r->get = pirq_piix_get;
>>  		r->set = pirq_piix_set;
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index
>> 31d77af..6a0359a 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2800,6 +2800,8 @@
>>  #define PCI_DEVICE_ID_INTEL_82454NX     0x84cb
>>  #define PCI_DEVICE_ID_INTEL_84460GX	0x84ea
>>  #define PCI_DEVICE_ID_INTEL_IXP4XX	0x8500
>> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MIN	0x8c40
>> +#define PCI_DEVICE_ID_INTEL_LYNXPOINT_LPC_MAX	0x8c5f
>>  #define PCI_DEVICE_ID_INTEL_IXP2800	0x9004
>>  #define PCI_DEVICE_ID_INTEL_S21152BB	0xb152
>>
>
>Seems we add every new GMCH or PCH anyway, why not just use the piix
>routines for any unknown (therefore presumably new) Intel PCH device?

Makes sense to me.
-Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/