linux-kernel - Re: [patch] x86, dumpstack: removed unneeded check in dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120128110034.GD3391@somewhere>
Date:	Sat, 28 Jan 2012 12:00:36 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Namhyung Kim <namhyung@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Clemens Ladisch <clemens@...isch.de>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] x86, dumpstack: removed unneeded check in dump_trace()

On Sat, Jan 28, 2012 at 01:52:46PM +0300, Dan Carpenter wrote:
> Smatch complains that we have some inconsistent NULL checking.  If
> "task" were NULL then it would lead to a NULL dereference later.  We
> can remove this test because earlier on in the function we have:
> 	if (!task)
> 		task = current;
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Frederic Weisbecker <fweisbec@...il.com>

> 
> diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
> index 6d728d9..af7785f 100644
> --- a/arch/x86/kernel/dumpstack_64.c
> +++ b/arch/x86/kernel/dumpstack_64.c
> @@ -129,7 +129,7 @@ void dump_trace(struct task_struct *task, struct pt_regs *regs,
>  	if (!stack) {
>  		if (regs)
>  			stack = (unsigned long *)regs->sp;
> -		else if (task && task != current)
> +		else if (task != current)
>  			stack = (unsigned long *)task->thread.sp;
>  		else
>  			stack = &dummy;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/