linux-kernel - Re: [PATCH] block: add missing block_bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F26326B.5010806@gmail.com>
Date:	Mon, 30 Jan 2012 15:02:19 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
	Steven Rostedt <rostedt@...dmis.org>, dm-devel@...hat.com
Subject: Re: [PATCH] block: add missing block_bio_complete() tracepoint

2012-01-30 2:54 PM, Tejun Heo wrote:
> On Mon, Jan 30, 2012 at 02:51:43PM +0900, Namhyung Kim wrote:
>> Hi,
>>
>> 2012-01-30 11:53 AM, Tejun Heo wrote:
>>> Hello,
>>>
>>> On Mon, Jan 30, 2012 at 11:49:43 AM +0900, Namhyung Kim wrote:
>>>> Yes, blktrace will see both of completions for rq and bio's it
>>>> contains from now on, and I thought it's your intention? For the
>>>> bounced bio's, it'll see one more completion per bio.
>>>
>>> Umm... no, blktrace users shouldn't see confusing outputs.  My point
>>> was that we should leave raw tracepoints as raw monitor points so that
>>> they can provide raw data to different users and filter from
>>> blktrace.c so that the existing users aren't disturbed.
>>>
>>
>> That means blktrace should not be changed, and not see duplicated
>> completions for rq based drivers at all?
>
> Yeap
>

I see. I'll prepare the patch soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/