linux-kernel - Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120130134205.GA3351@elte.hu>
Date:	Mon, 30 Jan 2012 14:42:05 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Michael D Labriola <mlabriol@...b.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Michael D Labriola <michael.d.labriola@...il.com>
Subject: Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot
 quirks


* Michael D Labriola <mlabriol@...b.com> wrote:

> > I realize that you only move code here - but it's worth 
> > cleaning it up a bit when touching it.
> 
> You are requesting that I clean up only the comments that 
> appear in the diff, correct?  I'll do that as well.

Yeah, and whatever other cleanliness detail you notice: when we 
touch some code it is the best opportunity to improve it.

I'd also suggest for ou to do it as two patches: first keep your 
existing patch then do a second one on top of it cleaning up any 
details, and send me both.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/