linux-kernel - Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFE2532E18.A9BD6FEB-ON85257995.004A4456-85257995.004ABE7E@gdeb.com>
Date:	Mon, 30 Jan 2012 08:36:24 -0500
From:	Michael D Labriola <mlabriol@...b.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Michael D Labriola <michael.d.labriola@...il.com>
Subject: Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

12345678901234567890123456789012345678901234567890123456789012345678901234567890
         1         2         3         4         5         6         7  8

Ingo Molnar <mingo@...e.hu> wrote on 01/30/2012 04:55:37 AM:

> I've applied your first two patches, thanks Michael!

Excellent!

> Regarding this patch, it does not apply cleanly to the latest 
> x86 tree:
> 
>  2 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/reboot.c
> 
> which you can pick up from:
> 
>  git pull git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
master

Ok, I based all of them off v3.2.  I'll rebase off of tip tonight after
the kids are in bed.  ;-)

> Also, a style nit, these comments:
> 
> > +   /* Write zero to CMOS register number 0x0f, which the BIOS POST
> > +      routine will recognize as telling it to do a proper reboot. 
(Well
> > +      that's what this book in front of me says -- it may only apply 
to
> > +      the Phoenix BIOS though, it's not clear).  At the same time,
> > +      disable NMIs by setting the top bit in the CMOS address 
register,
> > +      as we're about to do peculiar things to the CPU.  I'm not sure 
if
> > +      `outb_p' is needed instead of just `outb'.  Use it to be on the
> > +      safe side.  (Yes, CMOS_WRITE does outb_p's. -  Paul G.)
> > +    */
> 
> and the other similar comments that you move should be coverted 
> to the customary (multi-line) comment style:
> 
>   /*
>    * Comment .....
>    * ...... goes here.
>    */
> 
> specified in Documentation/CodingStyle.
> 
> I realize that you only move code here - but it's worth cleaning 
> it up a bit when touching it.

You are requesting that I clean up only the comments that appear in the
diff, correct?  I'll do that as well.

---
Michael D Labriola
Electric Boat
mlabriol@...b.com
401-848-8871 (desk)
401-848-8513 (lab)
401-316-9844 (cell)


 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/