linux-kernel - Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131112959.GJ3356@mwanda>
Date:	Tue, 31 Jan 2012 14:29:59 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Víctor M. Jáquez L. <vjaquez@...lia.com>
Cc:	Omar Ramirez Luna <omar.ramirez@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Armando Uribe <x0095078@...com>, devel@...verdev.osuosl.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/8] staging: tidspbridge: silence the compiler

On Tue, Jan 31, 2012 at 12:19:52PM +0100, Víctor M. Jáquez L. wrote:
> On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote:
> > On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> > > Silence the warning when compiling drv_interface.c
> > > 
> > > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@...lia.com>
> > 
> > What does the compiler warn about here?  Normally you would cut and
> > paste the warning into the commit message.  But at least give us a
> > hint.
> > 
> > You could also reformat that printk so the message is on one line.
> > 
> > 	dev_dbg(bridge,
> > 	        "%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
> > 		__func__, filp, offset, vma->vm_start, vma->vm_end,
> > 		vma->vm_page_prot, vma->vm_flags);
> 
> Ok. I'll do it.
> 
> I have a doubt about the process in this case: if this is the only
> modification request, should I resend all the patch set, or just this one?
> 

If you sent just the one, and you redid the printk() then it would
make the later patches not apply.

Maybe just send the one, with a fixed changelog and leave the patch
as is.  The problems in the printk() were not introduced in this
patch so I can't really complain about that.  A couple people have
already volunteered to fix that in a later patch.

regards,
dan carpenter


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)