linux-kernel - Re: [PATCH] fix readahead pipeline break caused by block plug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131114256.GA8796@localhost>
Date:	Tue, 31 Jan 2012 19:42:56 +0800
From:	Wu Fengguang <wfg@...ux.intel.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Shaohua Li <shaohua.li@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <axboe@...nel.dk>,
	Herbert Poetzl <herbert@...hfloor.at>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vivek Goyal <vgoyal@...hat.com>
Subject: Re: [PATCH] fix readahead pipeline break caused by block plug

On Tue, Jan 31, 2012 at 06:34:52AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 06:57:54PM +0800, Wu Fengguang wrote:
> > The problem is, there are a dozen of ->direct_IO callback functions.
> > While there are only two ->direct_IO() callers, one for READ and
> > another for WRITE, which are much easier to deal with.
> 
> So what?  Better do a bit more work now and keep the damn thing
> maintainable.

What if we add a wrapper function for doing

        blk_start_plug(&plug);
        ->direct_IO()
        blk_finish_plug(&plug);

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/