linux-kernel - Re: sched: fix compilation warning on !SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKfTPtC3UX9oKSkFr+x5DAX-8DydL8QPYZrbvbwBLghc0OEEfQ@mail.gmail.com>
Date:	Tue, 31 Jan 2012 13:20:56 +0100
From:	Vincent Guittot <vincent.guittot@...aro.org>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: sched: fix compilation warning on !SMP

On 31 January 2012 09:46, Vincent Guittot <vincent.guittot@...aro.org> wrote:
> 2012/1/31 Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>:
>> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>>
>>  CC      kernel/sched/fair.o
>> kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
>>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>> CC: Peter Zijlstra <a.p.zijlstra@...llo.nl>
>> CC: Vincent Guittot <vincent.guittot@...aro.org>
>> ---
>>  kernel/sched/fair.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 8e77a6b..4ab60a2 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
>>
>>  const struct sched_class fair_sched_class;
>>
>> -static unsigned long __read_mostly max_load_balance_interval = HZ/10;
>> -
>>  /**************************************************************
>>  * CFS operations on generic schedulable entities:
>>  */
>> @@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
>>  * Fair scheduling class load-balancing methods:
>>  */
>>
>> +static unsigned long __read_mostly max_load_balance_interval = HZ/10;
>> +
>
> Sorry for moving it out of SMP. Thanks for fixing this
>

Reviewed-by: Vincent Guittot <vincent.guittot@...aro.org>

>>  /*
>>  * pull_task - move a task from a remote runqueue to the local runqueue.
>>  * Both runqueues must be locked.
>> --
>> 1.7.7.6
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/