linux-kernel - Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131122016.GF32010@elte.hu>
Date:	Tue, 31 Jan 2012 13:20:16 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> On Mon, 30 Jan 2012 06:52:13 -0500, Steven Rostedt <rostedt@...dmis.org> wrote:
> > On Fri, 2012-01-27 at 13:32 +1030, Rusty Russell wrote:
> > > On Thu, 26 Jan 2012 19:39:46 +0100, Ingo Molnar <mingo@...e.hu> wrote:
> > > > Ok, i like this one best. Rusty, does it look good to you too?
> > > 
> > > No, the if (module) test belongs in the inline wrapper (since gcc knows
> > > that at compile time).
> > 
> > For some reason though it still adds 5K when we keep the 
> > code as a static inline. Note, my test config does have all 
> > the necessary modules to boot the box as compiled in (not as 
> > modules). If necessary, I could compile with a distro config 
> > and see what the differences are with that.
> > 
> > Rusty, the final decision is yours. If you believe that the 
> > added code size is worth having the static inlines, then 
> > I'll go back to the previous version that had that.
> 
> Wow, we're really bikeshedding this!

Hey, I don't think this is bikesheddig: we are shedding 
*kilobytes* of code from pretty hot codepaths, that kind of 
topic does deserve some detailed attention :-)

> I was completely wrong with the "it's usually a constant" of 
> course; it's usually ->owner.
> 
> So let's just out-of-line the entire thing.  I changed the 
> type to bool and s/_THIS_IP_/_RET_IP_/ -- is that sufficient?
> 
> Doesn't save me much here, though.  What are your stats?

I suspect it depends on inlining options in the .config plus on 
event tracing?

> Saves only 400 bytes of text here, but I don't do preempt or 
> tracepoints.

Most distro kernels do tracepoints so I guess that's where the 
size delta comes from :-) In any case:

Acked-by: Ingo Molnar <mingo@...e.hu>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/