linux-kernel - Re: [PATCH 1/4] mfd/ab8500: fix error path bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F296721.5040203@stericsson.com>
Date:	Wed, 1 Feb 2012 17:24:01 +0100
From:	Maxime Coquelin <maxime.coquelin@...ricsson.com>
To:	Linus WALLEIJ <linus.walleij@...ricsson.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alex MACRO <alex.macro@...ricsson.com>,
	Michel JAOUEN <michel.jaouen@...ricsson.com>
Subject: Re: [PATCH 1/4] mfd/ab8500: fix error path bug

Hi Linus,

On 02/01/2012 05:09 PM, Linus WALLEIJ wrote:
> From: Linus Walleij<linus.walleij@...aro.org>
>
> We were not freeing the irq properly in the error path in
> the AB8500 driver.
>
> Cc: Mark Brown<broonie@...nsource.wolfsonmicro.com>
> Signed-off-by: Maxime Coquelin<maxime.coquelin@...ricsson.com>
> Signed-off-by: Alex Macro<alex.macro@...ricsson.com>
> Signed-off-by: Michel Jaouen<michel.jaouen@...ricsson.com>
> Signed-off-by: Linus Walleij<linus.walleij@...aro.org>
> ---
>   drivers/mfd/ab8500-core.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index 53e2a80..bf823d2 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500)
>   	return ret;
>
>   out_freeirq:
> -	if (ab8500->irq_base) {
> +	if (ab8500->irq_base)
>   		free_irq(ab8500->irq, ab8500);
>   out_removeirq:
> +	if (ab8500->irq_base)
>   		ab8500_irq_remove(ab8500);
>   	}
Shouldn't the above brace to be removed?
>   	return ret;

Regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/