linux-kernel - Re: [PATCH 1/4] mfd/ab8500: fix error path bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ_YDoxDWx4oG62=NPeaPZanUU159PCaQy5VUsSDim+ZA@mail.gmail.com>
Date:	Wed, 1 Feb 2012 21:28:43 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Maxime Coquelin <maxime.coquelin@...ricsson.com>
Cc:	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Alex MACRO <alex.macro@...ricsson.com>,
	Michel JAOUEN <michel.jaouen@...ricsson.com>
Subject: Re: [PATCH 1/4] mfd/ab8500: fix error path bug

On Wed, Feb 1, 2012 at 5:24 PM, Maxime Coquelin
<maxime.coquelin@...ricsson.com> wrote:
> On 02/01/2012 05:09 PM, Linus WALLEIJ wrote:

>> --- a/drivers/mfd/ab8500-core.c
>> +++ b/drivers/mfd/ab8500-core.c
>> @@ -956,9 +956,10 @@ int __devinit ab8500_init(struct ab8500 *ab8500)
>>        return ret;
>>
>>  out_freeirq:
>> -       if (ab8500->irq_base) {
>> +       if (ab8500->irq_base)
>>                free_irq(ab8500->irq, ab8500);
>>  out_removeirq:
>> +       if (ab8500->irq_base)
>>                ab8500_irq_remove(ab8500);
>>        }
>
> Shouldn't the above brace to be removed?

Yes of course, thanks for spotting this! Fixed it in my patch queue.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/