linux-kernel - Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2BBBDA.90900@mvista.com>
Date:	Fri, 03 Feb 2012 14:50:02 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
CC:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.

Hello.

On 03-02-2012 11:14, Tomoya MORINAGA wrote:

> Problem:
>   The GPIO ports used for detecting VBUS may be different
>   on each platform.
>   This should be easily modifiable.
> Solution:
>   In configuration, GPI port number is specified.

    Isn't it better to pass this with driver's platform data.

> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/