linux-kernel - Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120209075629.GJ1121@legolas.emea.dhcp.ti.com>
Date:	Thu, 9 Feb 2012 09:56:30 +0200
From:	Felipe Balbi <balbi@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Tomoya MORINAGA <tomoya.rohm@...il.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH 3/3] pch_udc: Specifies GPI port number at configuration.

On Fri, Feb 03, 2012 at 02:50:02PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 03-02-2012 11:14, Tomoya MORINAGA wrote:
> 
> >Problem:
> >  The GPIO ports used for detecting VBUS may be different
> >  on each platform.
> >  This should be easily modifiable.
> >Solution:
> >  In configuration, GPI port number is specified.
> 
>    Isn't it better to pass this with driver's platform data.

Yes, please re-factor this port. This doesn't fit as a compile-time
choice.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)