linux-kernel - Re: [PATCH] Handling of unused variable 'do-numainfo on compilation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120203145304.GA18335@tiehlicka.suse.cz>
Date:	Fri, 3 Feb 2012 15:53:04 +0100
From:	Michal Hocko <mhocko@...e.cz>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Geunsik Lim <geunsik.lim@...il.com>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] Handling of unused variable 'do-numainfo on compilation
 time

On Fri 03-02-12 14:39:50, Johannes Weiner wrote:
> Michal, this keeps coming up, please decide between the proposed
> solutions ;-)

Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ?

> 
> On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote:
> > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc compiler.
> > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1.
> > 
> > Signed-off-by: Geunsik Lim <geunsik.lim@...sung.com>
> > ---
> >  mm/memcontrol.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 556859f..4e17ac5 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page)
> >  	/* threshold event is triggered in finer grain than soft limit */
> >  	if (unlikely(mem_cgroup_event_ratelimit(memcg,
> >  						MEM_CGROUP_TARGET_THRESH))) {
> > -		bool do_softlimit, do_numainfo;
> > +		bool do_softlimit;
> > +#if MAX_NUMNODES > 1
> > +                bool do_numainfo;
> > +#endif
> >  
> >  		do_softlimit = mem_cgroup_event_ratelimit(memcg,
> >  						MEM_CGROUP_TARGET_SOFTLIMIT);
> > -- 
> > 1.7.8.1
> > 

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/